Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ports Overlay] New feature draft spec (Superseded by #6981) #6963

Closed
wants to merge 7 commits into from

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Jun 19, 2019

This is a specification draft for a new feature.

This document proposes adding a new option --overlay-ports to the vcpkg install, vcpkg update, and vcpkg upgrade commands to specify additional paths containing ports.
These locations will be searched when resolving port names during package installation, and override ports in <vcpkg-root>/ports.

Any feedback is welcomed.

@vicroms vicroms added wip info:internal This PR or Issue was filed by the vcpkg team. labels Jun 19, 2019
@martin-s
Copy link
Contributor

martin-s commented Jun 19, 2019

I appreciate the draft, but two questions come to my mind:

  • Example Add libogg/libvorbis/libvorbisfile #1: where is the installed folder created? Is there one installed folder or more?

  • what about vcpkg depend-info? When ports are splitted over different folders, I would like to have a dependency graph as well.

@vicroms
Copy link
Member Author

vicroms commented Jun 19, 2019

Hi @martin-s

There's still just one installed folder, its location remains the same <vcpkg-root>/installed/<triplet>.

  • what about vcpkg depend-info? when port are split over different folders, I would like to have a dependency graph as well.

Noted, vcpkg depend-info should also accept the --overlay-ports option.

@cenit
Copy link
Contributor

cenit commented Jun 19, 2019

Developer Alice and her team use vcpkg to acquire OpenCV and some other packages. She has even contributed many patches to add features to the OpenCV 3 port in vckpg. But, one day, she notices that a PR to update OpenCV to the next major version has been merged.

A long time ago in a galaxy far, far away...

the upgrade to OpenCV 4 really hurts deep inside, it seems you are not safe 🤣

apart from that, this is a really nice feature. Thanks for your work on it!!! It will be terrific for vcpkg deployment in many situations!

docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
docs/specifications/ports-overlay.md Outdated Show resolved Hide resolved
@vicroms
Copy link
Member Author

vicroms commented Jun 21, 2019

Superseded by #6981

@vicroms vicroms closed this Jun 21, 2019
@vicroms vicroms changed the title [Ports Overlay] New feature draft spec [Ports Overlay] New feature draft spec (Superseded by #6981) Jun 21, 2019
@vicroms vicroms deleted the pr/ports-overlay branch June 26, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants