Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ninja #6897

Closed
wants to merge 2 commits into from
Closed

Bump ninja #6897

wants to merge 2 commits into from

Conversation

skychef
Copy link

@skychef skychef commented Jun 14, 2019

Bump ninjabuild to version 1.9.0.

According to https://github.com/ninja-build/ninja/releases version 1.8.2 was released in 2017 and 1.9.0 is now close to six months old. I noticed a slight speed improvement with this newer version and no regressions.

Bump ninjabuild to version 1.9.0.

According to https://github.com/ninja-build/ninja/releases version 1.8.2 was released in 2017 and 1.9.0 is now close to six months old. I noticed a slight speed improvement with this newer version and no regressions.
@Rastaban Rastaban self-assigned this Jun 14, 2019
Update the core version of ninja build to 1.9.0.

As bsd is not a supported platform and there is no updated bsd binary, the version unfortunately remains the same.
The duplication of code between this file and vcpkg_find_acquire_program.cmake should possibly be addressed too.
@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ skychef sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@skychef
Copy link
Author

skychef commented Jun 14, 2019

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Many open source projects do not require the agreement of a "contributor license agreement" before accepting contributions.
Many open source projects require the agreement to a code of conduct. Not a license agreement. Maybe you have become confused between the two?

In approximately 20 years of open source software development, across numerous projects, I can safely say that I have never signed one single "contributor license agreement." Not once. Doing so would certainly be the exception and not the rule.

Arbitrary contributor license agreements are appropriate for employees and contractors. Not open source project contributors who are not employed by Microsoft.

If the sentiment:

Thank you for your submission, we really appreciate it.

were really true, then it wouldn't be immediately proceeded by an attempt to violate my legal rights by advocating that I should sign away protections afforded to me by law and presenting the ability to do so as a trivial formality.

I have filled an issue report:
#6899
This type of passive aggressive attempt at the removal of legal protections afforded to me by the rule of law, by a corporation, is just wrong.

I am not signing your contributor license agreement.
It violates my existing legal rights in a way in which I do not concede is fair.

@Rastaban
Copy link
Contributor

duplicate of #6791

@Rastaban Rastaban closed this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants