-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[soxr] Add new port #6478
[soxr] Add new port #6478
Conversation
Hi @ThijsWithaar, thanks for the new port. Here are the test results from the current CI system:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm...
"Build type, one of: None Debug Release RelWithDebInfo MinSizeRel." FORCE) | ||
endif () | ||
|
||
-option (BUILD_TESTS "Build sanity-tests." ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also easier through the port file
vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
OPTIONS
-DBUILD_TESTS=OFF
-DWITH_OPENMP=OFF
-DWITH_LSR_BINDINGS=OFF
....
Ok, update to use cmake settings instead of a path. It seems I still have a warning:
And an error which needs addressing:
It does build fine on my machine, so I'm not completely sure what's going on. Is it obvious for you what's going on ? |
/azp run |
Thanks for the new port, @ThijsWithaar! |
Request to add the soxr library, see also #3557.