Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[septag-sx] Add new port #6327

Merged
merged 5 commits into from
Jul 1, 2019
Merged

[septag-sx] Add new port #6327

merged 5 commits into from
Jul 1, 2019

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 6, 2019

https://github.com/septag/sx
BTW, is the package name too short?
septag/sx#11

@Rastaban
Copy link
Contributor

Rastaban commented May 6, 2019

I see failures on uwp triplets and arm64-windows. Are those expected?

@vicroms do we have a policy regarding the length of names?

@vicroms
Copy link
Member

vicroms commented May 6, 2019

There's no policy regarding specifically to name length, but searching in repology.org returns a bunch of similarly named sx packages.

In Fedora, sx refers to a reporting tool, but on Arch-Linux it refers to the septag/sx repo (same as this PR).

I don't see any other obvious name for this library, unless we make the package name septag-sx.

@vicroms
Copy link
Member

vicroms commented May 6, 2019

@Rastaban
Copy link
Contributor

Rastaban commented May 6, 2019

Okay, so go ahead and change the name (maybe septag-sx?)

@myd7349
Copy link
Contributor Author

myd7349 commented May 7, 2019

@Rastaban @vicroms Thanks for your helpful reply. Maybe we can document it somewhere(Also this: #5817 (comment)).
I think septag-sx is better.
I didn't test it with a real project yet, I will test it later. Then I maybe able to figure out what happens to UWP and ARM.

@myd7349 myd7349 changed the title [WIP][sx] Add new port [WIP][septag-sx] Add new port May 7, 2019
@vicroms vicroms added the wip label May 7, 2019
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 9, 2019

Hi @myd7349,here are the test results from the current CI system. Please refer to the attachment. Hope this will hep you.

arm64-windows master test notes
septag-sx Fail New Port
x64-uwp master test notes
septag-sx Fail New Port
arm-uwp master test notes
septag-sx Fail New Port

failureLogs.zip

@myd7349
Copy link
Contributor Author

myd7349 commented May 9, 2019

Hi! @NancyLi1013 Thanks!
I will test it as soon as possible.

@Rastaban
Copy link
Contributor

A step toward improving the docs: #6397

@myd7349 myd7349 changed the title [WIP][septag-sx] Add new port [septag-sx] Add new port May 11, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented May 11, 2019

Test with https://github.com/myd7349/Ongoing-Study/tree/master/cpp/CMake/vcpkg/sx_example. These triplets are tested:

  • x86-windows
  • x86-windows-static
  • x64-windows
  • x64-windows-static
  • x64-linux

UWP/ARM/ARM64 are not supported currently: https://github.com/septag/sx/blob/master/CMakeLists.txt#L134-L141

@NancyLi1013
Copy link
Contributor

@myd7349 ,thanks for your contribution. All test results are normal now except for uwp/arm/arm64 that are not supported.

@grdowns
Copy link
Contributor

grdowns commented Jul 1, 2019

Thanks for the new port, @myd7349!

@grdowns grdowns merged commit 012e993 into microsoft:master Jul 1, 2019
@myd7349 myd7349 deleted the sx-init branch July 2, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants