Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[giflib]fix compile error in x64-uwp #5578

Merged
merged 6 commits into from
Mar 28, 2019
Merged

[giflib]fix compile error in x64-uwp #5578

merged 6 commits into from
Mar 28, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 7, 2019 •
edited
Loading

Installing giflib will prompt some functions to be unsafe, so I added macro -D_CRT_SECURE_NO_WARNINGS and replaced some safe functions to avoid compilation failure.

See #3043.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 7, 2019
@JackBoosY JackBoosY requested a review from Cheney-W March 7, 2019 08:24
@grdowns grdowns self-assigned this Mar 7, 2019
@JackBoosY JackBoosY requested a review from Rastaban March 19, 2019 02:32
@JackBoosY
Copy link
Contributor Author

@Rastaban I have modified code, please check it out. Thank you.

@Rastaban
Copy link
Contributor

Resolved merge conflict

@Rastaban Rastaban merged commit 6e25f7e into microsoft:master Mar 28, 2019
@qis
Copy link
Contributor

qis commented Apr 1, 2019 •
edited
Loading

@JackBoosY @Rastaban Could you please revert this change? It breaks compilation on Linux. Tested on Ubuntu 18.04.2 LTS.

Edit: I mean "you can't link against it". It compiles just fine, which is why it probably slipped by.

/opt/vcpkg/installed/x64-linux/debug/lib/libgif.a(egif_lib.c.o): In function `EGifOpenFileName':
/opt/vcpkg/buildtrees/giflib/src/5.1.4-8e625bd21e/lib/egif_lib.c:63: undefined reference to `_open'
/opt/vcpkg/buildtrees/giflib/src/5.1.4-8e625bd21e/lib/egif_lib.c:66: undefined reference to `_open'
/opt/vcpkg/buildtrees/giflib/src/5.1.4-8e625bd21e/lib/egif_lib.c:76: undefined reference to `_close'
/opt/vcpkg/installed/x64-linux/debug/lib/libgif.a(egif_lib.c.o): In function `EGifOpenFileHandle':
/opt/vcpkg/buildtrees/giflib/src/5.1.4-8e625bd21e/lib/egif_lib.c:121: undefined reference to `_fdopen'

Here is the "workaround" I have to use now:

https://github.com/qis/vcpkg-test/blob/2d0693df8f04930f0933daaceef0519f490d1db9/giflib/src/main.cpp#L16

ras0219-msft added a commit that referenced this pull request Apr 2, 2019
@ras0219-msft
Revert "[giflib]fix compile error in x64-uwp (#5578)"
dd02065 
This reverts commit 6e25f7e.
cenit added a commit to cenit/vcpkg that referenced this pull request May 9, 2019
@cenit
[giflib] revert again microsoft#5578, when did it came back again??
1e92a3b
Rastaban pushed a commit that referenced this pull request May 9, 2019
@cenit @Rastaban
[freeimage,freeglut,giflib,libwebp] port patches from #5169 (#6364)
9c33de2 
* [freeimage] improve compatibility with other ports, using typedefs identical to other headers to avoid errors
* [libwebp] fixes for non-win32 systems
* [giflib] revert again #5578
* [freeglut] add missing wrapper for linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Awaiting requested review from Cheney-W

@Rastaban Rastaban Awaiting requested review from Rastaban

Assignees

@ras0219-msft ras0219-msft

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JackBoosY @Rastaban @qis @ras0219-msft @grdowns