Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lest] Add lest v1.34.1 (was: v1.34.0) #5353

Merged
merged 3 commits into from
Feb 19, 2019

Conversation

martinmoene
Copy link
Contributor

First version of lest C++ tiny test framework.

See also issue #1489.

@Codiferous Codiferous self-assigned this Feb 15, 2019
@Codiferous
Copy link
Contributor

@martinmoene Thanks for this PR! It looks pretty good to me, but I have one question.

I took the "Example Usage" code from the lest github repo and attempted to build. The example doesn't build because this port installs the headers into the lest folder, so the include needs to be modified to #include <lest/lest.hpp>. I just want to confirm that this is intentional/how the library is intended to be used before merging this PR. 😄

@martinmoene
Copy link
Contributor Author

@Codiferous Ah, good catch, I'll look into it and update/report back.

To support vcpkg installations, examples now specify folder 'lest' in the include directives, like: #include "lest/lest.hpp".
@martinmoene martinmoene changed the title [lest] Add lest v1.34.0 [lest] Add lest v1.34.1 (was: v1.34.0) Feb 16, 2019
@martinmoene
Copy link
Contributor Author

@Codiferous I changed the occurrences of #include "lest.hpp" and the like to #include "lest/lest.hpp" and tried it successfully with Visual Studio 2017. Release tag now is v1.34.1.

@martinmoene
Copy link
Contributor Author

Argh! lest version needs updating... back in a minute...

@martinmoene
Copy link
Contributor Author

martinmoene commented Feb 16, 2019

@Codiferous ok, done.

@Codiferous
Copy link
Contributor

@martinmoene I updated the hash for lest because it wasn't matching. With that change, everything looks beautiful. I'm really happy to have lest in vcpkg! 😄

@Codiferous Codiferous merged commit a1e2c81 into microsoft:master Feb 19, 2019
@martinmoene
Copy link
Contributor Author

Thanks!

@martinmoene martinmoene deleted the lest-1.34.0 branch February 20, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants