Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new port Spectralib 0.7.0 #5129

Merged
merged 2 commits into from
Jan 26, 2019
Merged

new port Spectralib 0.7.0 #5129

merged 2 commits into from
Jan 26, 2019

Conversation

TheScarfix
Copy link
Contributor

No description provided.

@Codiferous Codiferous self-assigned this Jan 24, 2019
@Codiferous
Rename spectralib -> spectra
cd361b0 
I'm making this change based on the naming in the other repositories
that the library is packaged in (DPorts, FreeBSD Ports) and the
terminology used on the website. Code examples use Spectra* for the
prefixes, so I think using "Spectra" is better than "spectralib".
@Codiferous
Copy link
Contributor

I've gone ahead and renamed this port from spectralib to spectra, based on common code examples on the main project website, its name in other repositories, and the way the project website talks about the project ("Spectra is designed...").

@Codiferous
Copy link
Contributor

Okay, this change looks good after doing a CI run (nice work!), so I'll merge the PR. Thanks for this PR! 😄

@Codiferous Codiferous merged commit 715aefc into microsoft:master Jan 26, 2019
@TheScarfix TheScarfix deleted the spectralib-0.7.0 branch January 27, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Codiferous Codiferous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheScarfix @Codiferous