-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[czmq] Add new port #4979
[czmq] Add new port #4979
Conversation
Whoops! After updated to 2018-12-15, the linux x64 build is failed. It may be caused by https://github.com/zeromq/czmq/blob/master/CMakeLists.txt#L186-L201 |
502c602
to
0d7d529
Compare
|
202ac42
to
f6898b4
Compare
I'm new to vcpkg, but I was attempting to use this branch by making a local merge with master. I ran into an issue with libsodium where I ended up commenting out the debug DLL/lib installs from ports/libsodium/portfile.cmake , as they were missing. This could be because I have
in triplets/x64-windows.cmake . In any case czmq fails for me like so:
I had run vcpkg install zeromq though and it reports it's installed:
The zeromq DLL I found was buildtrees\zeromq\x64-windows-rel\bin\libzmq-mt-4_3_2.dll . There was also a .lib under the lib folder. I'm not sure why CMake can't find libzmq. |
@tg2k Thanks for your interest in this PR. This PR still has room for improvement.
I am on a bussiness trip these days. I will improve this PR when I am back. |
A big update today! Test on Windows with
Test on Ubuntu with
httpd feature failed on Linux because of: #6516 |
It is very strange: Both |
Hi! @ras0219-msft I think I have finished this port now. Cheers! |
Looks good, @myd7349! I caught a typo in use of the feature flag, it will be mergeable when finished. Thanks for adding |
Hi! @grdowns Thanks! Should I squash those commits to keep the commit message clean? |
No need! We squash commits when we perform a merge (unless we make a mistake) 😆 |
Fix #5164 .