Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg: fix toolchain to correctly set the CMAKE_SYSTEM_PROCESSOR vari… #4970

Closed
wants to merge 1 commit into from
Closed

vcpkg: fix toolchain to correctly set the CMAKE_SYSTEM_PROCESSOR vari… #4970

wants to merge 1 commit into from

Conversation

studiofuga
Copy link
Contributor

…able

Some build fails because cmake expects the CMAKE_SYSTEM_PROCESSOR to
be correctly set with the system processor flavour.
scripts/toolchains/linux.cmake fails to set it, while other
toolchains correctly set it (see osx.cmake) for example.
This patch fix this bug.

@studiofuga
vcpkg: fix toolchain to correctly set the CMAKE_SYSTEM_PROCESSOR vari…
8edac6f 
…able

Some build fails because cmake expects the CMAKE_SYSTEM_PROCESSOR to
be correctly set with the system processor flavour.
scripts/toolchains/linux.cmake fails to set it, while other
toolchains correctly set it (see osx.cmake) for example.
This patch fix this bug.
@studiofuga studiofuga mentioned this pull request Dec 13, 2018
Closed
@ras0219-msft ras0219-msft mentioned this pull request Feb 1, 2019
Closed
@ras0219-msft ras0219-msft self-assigned this Feb 1, 2019
@ras0219-msft ras0219-msft assigned vicroms and unassigned ras0219-msft Feb 25, 2019
@LarryIII
Copy link
Contributor

LarryIII commented Mar 6, 2019

I am seeing new build failures on the following ports with this PR. Let me know if you need build log.

Processing x64-linux                      579 vs 585
     caffe2                        **regression**                Fail vs Pass
     forest                        **regression**                Fail vs Pass
     libuuid                       **regression**                Fail vs Pass
     sobjectizer                   **regression**                Fail vs Pass

@vicroms vicroms mentioned this pull request Mar 15, 2019
Closed
@Rastaban
Copy link
Contributor

Rastaban commented May 2, 2019

This would probably fix issues currently seen on #4635

@vicroms
Copy link
Member

vicroms commented May 2, 2019

I had an open PR to address this same issue, but it got closed when we deleted all the branches on this repo.

I'll resubmit it once I have more time to keep working on the issue.

#5697

@JackBoosY JackBoosY mentioned this pull request May 15, 2019
Closed
@vicroms
Copy link
Member

vicroms commented Jul 15, 2019

Fixed in #6872

@vicroms vicroms closed this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vicroms vicroms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@studiofuga @LarryIII @Rastaban @vicroms @ras0219-msft