Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[realsense2] fix cmake for linux #4564

Merged
merged 3 commits into from
Mar 7, 2019
Merged

[realsense2] fix cmake for linux #4564

merged 3 commits into from
Mar 7, 2019

Conversation

edmBernard
Copy link
Contributor

@edmBernard edmBernard commented Oct 25, 2018 •
edited
Loading

Previous CMake config crash on linux

Note: I note that at this time realsense2 depends on libusb, glfw3 from system and not from vcpkg

@edmBernard edmBernard changed the title [realsense2] fix quotation mark in cmake command WIP [realsense2] fix quotation mark in cmake command Oct 25, 2018
@edmBernard edmBernard changed the title WIP [realsense2] fix quotation mark in cmake command [realsense2] fix cmake for linux Oct 25, 2018
@Rastaban Rastaban self-assigned this Feb 28, 2019
@PhoebeHui
Copy link
Contributor

@edmBernard, thanks for contributing to vcpkg!

All triplets build successfully:

Processing arm-uwp                        406 vs 406
Processing arm64-windows                  458 vs 458
Processing x64-linux                      592 vs 592
Processing x64-osx                        584 vs 584
Processing x64-uwp                        434 vs 434
Processing x64-windows                    846 vs 846
Processing x64-windows-static             765 vs 765
Processing x86-windows                    826 vs 826

@Rastaban Rastaban merged commit 1b37324 into microsoft:master Mar 7, 2019
vicroms added a commit that referenced this pull request Mar 7, 2019
@vicroms
Revert "[realsense2] fix cmake for linux (#4564)"
608260c 
This reverts commit 1b37324.
vicroms added a commit that referenced this pull request Mar 7, 2019
@vicroms
Revert "[realsense2] fix cmake for linux (#4564)" (#5575)
4b150c0 
This reverts commit 1b37324.
@vicroms
Copy link
Member

vicroms commented Mar 7, 2019

@edmBernard

Sorry about the revert, the CONTROL version needs to be bumped whenever you make a change to the portfile.

I tried to push the change to your branch myself, but got permission denied :(

Just bump the version in CONTROL to Version: 2.16.1-1 and that should do it.

@edmBernard edmBernard deleted the fix_realsense2 branch March 7, 2019 12:08
@edmBernard edmBernard restored the fix_realsense2 branch March 7, 2019 12:09
@edmBernard
Copy link
Contributor Author

edmBernard commented Mar 7, 2019 •
edited
Loading

@vicroms I add a commit with new version edmBernard@357d1bf
It will not appear does I need to do a new pull request ?

@edmBernard edmBernard mentioned this pull request Mar 11, 2019
Merged
@claudiofantacci claudiofantacci mentioned this pull request Mar 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rastaban Rastaban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmBernard @PhoebeHui @vicroms @Rastaban