[vsg] Update the glslang minimum required version to 15 #42294
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of glslang in vcpkg (15.0.0) to prevent vsg from building without glsl compiler support and causing a runtime error
dg0yt
reviewed
Nov 21, 2024
Style suggestions accepted Co-authored-by: Kai Pastor <[email protected]>
Cheney-W
added
the
category:port-bug
Cheney-W
approved these changes
Nov 22, 2024
|
Can you remove the version check in the build entirely rather than hardcoding a particular version from a different port? |
|
|
My understanding is that the package maintainer plans to address this in the next release, so I would prefer to defer to them. |
|
ATM this PR will break the build for users which explicitly select glslang 14 to avoid the problem which the PR wants to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the glslang minimum required version to the latest version of glslang in vcpkg (15.0.0).
Implemented by passing in an option to vcpkg_cmake_configure().
Failing to do so will prevent vsg from building with glsl compiler support, and will result in a runtime error.
Further information can be found here:
vsg-dev/VulkanSceneGraph#1326
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.