Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basisu] update to v1.50.0 #41901

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[basisu] update to v1.50.0 #41901

merged 1 commit into from
Nov 5, 2024

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Nov 1, 2024

Patches upstreamd here: BinomialLLC/basis_universal#383

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 2, 2024

For optional targets, it is sometimes less intrusive to only control build and install instead of adding conditions everywhere. i.e.

# not conditional; not modified
add_library(examples ...)
target_link_libraries(examples PRIVATE mainlib)

# only condition
if(EXAMPLES)
    install(TARGETS examples ...)
else()
    set_target_properties(examples PROPERTIES EXCLUDE_FROM_ALL 1)
endif()

@aminya
Copy link
Contributor Author

aminya commented Nov 2, 2024

Thanks for the tip. Here I went with the proper way as I did the same in the upstream PR.

@jimwang118 jimwang118 self-assigned this Nov 4, 2024
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 4, 2024
@jimwang118
Copy link
Contributor

Usage test passed on x64-windows triplet.

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Nov 4, 2024
@vicroms vicroms merged commit 9d163f0 into microsoft:master Nov 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants