-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-scripts] Fix rpath fixup; add test #37964
Conversation
Paths may contain characters which have special meaning in a regex: +, (, ), ^, $...
@ras0219, @data-queue, @vicroms, @BillyONeal, and I agree that fixing regex handling is absolutely good. However, expanding the definition of where debug tools should go depends on the specific use cases and we don't know of any generic use cases at this time. That said, the DBUS situation specifically is unusual and we do believe we need to deploy the debug Daemon exe. |
Sorry, but I cannot follow. For numbers, see #37736 (comment). Of course, this includes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU for the tests.
Nice, can we move the dbus debug tools to a proper location now? |
My understanding is that the dbus situation is different because it's about how the library finds the exe but I didn't pay super close attention to the details there; I poked @data-queue and @ras0219-msft who did |
I don't think I ever saw a mention of this twist. It was always about the exes finding their libs. And a little bit about cmake prefix and find stuff. Nothing specific about dbus, except the reason why the debug tools would be needed. |
The specific weird thing about dbus is that the executable is launched by the library, which means it's like a configuration-dependent "cacert.pem" thing that needs to be deployed with the final user's application. This means that users of the debug version of libdbus actually do need a debug variant of the executable dbus-daemon. It is a non-goal (but acceptable) that the debug variant of dbus-daemon is executable from the installed directory; it eventually needs to be copied by the user into their overall product and probably rpath-adjusted to work in that environment. |
Fix fixup for debug tools, #37736 (comment).
Fix fixup for paths with regex chars, #37984.