[zeromq] Updated to the released 4.3.5 version. #36194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Cheney-W
added
the
category:port-update
Cheney-W
changed the title
Cheney-W
reviewed
Jan 16, 2024
Cheney-W
reviewed
Jan 16, 2024
Co-authored-by: Cheney Wang <[email protected]>
Co-authored-by: Cheney Wang <[email protected]>
Cheney-W
approved these changes
Jan 17, 2024
Osyotr
pushed a commit
to Osyotr/vcpkg
that referenced
this pull request
Jan 23, 2024
* Updated the port for ZeroMQ to the released 4.3.5 version. * Corrected port version and updated baseline file. * Updated git-tree object id for zeromq port v4.3.5#0 * Update ports/zeromq/portfile.cmake Co-authored-by: Cheney Wang <[email protected]> * Update ports/zeromq/vcpkg.json Co-authored-by: Cheney Wang <[email protected]> * Updated the version metadata file for ZeroMQ port again. --------- Co-authored-by: Rostyslav Skrypnyk <[email protected]> Co-authored-by: Cheney Wang <[email protected]>
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
* Updated the port for ZeroMQ to the released 4.3.5 version. * Corrected port version and updated baseline file. * Updated git-tree object id for zeromq port v4.3.5#0 * Update ports/zeromq/portfile.cmake Co-authored-by: Cheney Wang <[email protected]> * Update ports/zeromq/vcpkg.json Co-authored-by: Cheney Wang <[email protected]> * Updated the version metadata file for ZeroMQ port again. --------- Co-authored-by: Rostyslav Skrypnyk <[email protected]> Co-authored-by: Cheney Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ZeroMQ port to point to the released 4.3.5 version.
The current port for ZeroMQ (libzmq) points to a non-release commit that still reports to have version 4.3.5. It seems the version of libzmq was already incremented to 4.3.5, although it was not the final version for that release. Therefore, it is deceiving for the package consumers because calling
find_package()in CMake will set${ZeroMQ_VERSION}to 4.3.5, while the installed version will differ from the one released under the tag 4.3.5, see https://github.com/zeromq/libzmq/releases/tag/v4.3.5../vcpkg x-add-version --alland committing the result.