Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtwebengine] fix debug builds #35712

Closed

Conversation

Neumann-A
Copy link
Contributor

simply fix debug builds by applying the same change to LogStreamer<V,T,Ts...>

@carsten-grimm-at-ipolog
Copy link
Contributor

@Neumann-A While you are working on this, could you check if the binaries for the debug build are copied into the right directories? I seem to remember that I was missing a debug version of the QtWebEngineProcess executable. I was unable to pursue the matter, due to the other build error.

If this is out of scope for this pull request, I can check if the issue still exists once I can build the port and create a separate issue, if need be. Thank you.

@Neumann-A
Copy link
Contributor Author

Vcpkg generally tries to only keep release versions of executables around. Is the debug version really needed?

@carsten-grimm-at-ipolog
Copy link
Contributor

Vcpkg generally tries to only keep release versions of executables around. Is the debug version really needed?

For our use case, yes. We have tried to debug our application with the release build of the qt web engine process, but we could not get that to work.

If it is too much of a hassle, we can manually copy the debug binaries from the build tree to the respective folders, but it would be nice if we could skip that step.

@dg0yt
Copy link
Contributor

dg0yt commented Dec 15, 2023

Debug executables are ultra-heavy for static triplets.

is the debug version really needed?

@Neumann-A
Copy link
Contributor Author

Qtwebengine only allows dynamic builds. Otherwise you'll get into symbol hell due to all the vendored third party libs in chromium.

@Neumann-A
Copy link
Contributor Author

@carsten-grimm-at-ipolog: Yeah the debug exe gets installed however it gets removed by vcpkg_copy_tools. So it is definitely out of scope for this PR.

@carsten-grimm-at-ipolog
Copy link
Contributor

@carsten-grimm-at-ipolog: Yeah the debug exe gets installed however it gets removed by vcpkg_copy_tools. So it is definitely out of scope for this PR.

Thank you for taking the time to look into this and thank you for the insight. This might help us build a better workaround on our end.

@BillyONeal
Copy link
Member

#35640 is testing with the updated compiler

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 18, 2023
@Neumann-A Neumann-A closed this Dec 18, 2023
@Neumann-A Neumann-A deleted the qtwebengine-fix-debug-builds branch December 18, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants