-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qtwebengine] fix debug builds #35712
[qtwebengine] fix debug builds #35712
Conversation
@Neumann-A While you are working on this, could you check if the binaries for the debug build are copied into the right directories? I seem to remember that I was missing a debug version of the QtWebEngineProcess executable. I was unable to pursue the matter, due to the other build error. If this is out of scope for this pull request, I can check if the issue still exists once I can build the port and create a separate issue, if need be. Thank you. |
Vcpkg generally tries to only keep release versions of executables around. Is the debug version really needed? |
For our use case, yes. We have tried to debug our application with the release build of the qt web engine process, but we could not get that to work. If it is too much of a hassle, we can manually copy the debug binaries from the build tree to the respective folders, but it would be nice if we could skip that step. |
Debug executables are ultra-heavy for static triplets.
|
Qtwebengine only allows dynamic builds. Otherwise you'll get into symbol hell due to all the vendored third party libs in chromium. |
@carsten-grimm-at-ipolog: Yeah the debug exe gets installed however it gets removed by |
Thank you for taking the time to look into this and thank you for the insight. This might help us build a better workaround on our end. |
#35640 is testing with the updated compiler |
simply fix debug builds by applying the same change to
LogStreamer<V,T,Ts...>