[vcpkg-scripts][gmp][nettle] Use VSCLANG #35335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am against this. There is no reason to force clang from VS. |
Only against not accepting another installed clang (via LLVMInstallDir, or even from |
|
I am against forcing clang from VS. So if it is not installed you could print a info message and then go get LLVM. I mean the current behavior is already -> get clang -> if installed in VS use that -> otherwise download llvm and use that. (Third way: Have the variable set in the triplet and directly feed it.) |
Adela0814
added
the
category:tool-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked and revised from #31228:
Use clang from Visual Studio for assembler or fail with a clear error message. Don't download llvm
For #28912 and several similar reports.