-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dylib] New port #34578
[dylib] New port #34578
Conversation
Signed-off-by: Martin Olivier <martin.olivier@live.fr>
@microsoft-github-policy-service agree |
Signed-off-by: Martin Olivier <martin.olivier@live.fr>
Signed-off-by: Martin Olivier <martin.olivier@live.fr>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Thanks for your review @JonLiu1993 I have an issue with the installation of the port.
Then, when building a project that uses
I expect something like
|
@martin-olivier, I tested the usage on my machine by your PR and I tested successfully.
usageTest.cpp:
config:
build:
|
Hello @JonLiu1993, Sorry, I forgot to specify the I have re-tested it and it works well. |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.