-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[json-c] update to 0.17 2023-08-12 #34381
Conversation
Please get failure logs here:
|
Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review". |
|
You need to update both |
Ping @jswillard Any progress here? |
As a heads up we're backporting the clamav - json-0.17 compatibility fix for 1.1 and 1.0 (just merged the fix a bit ago) and will be publishing the new versions sometime next week if all goes well. You're of course welcome to upgrade to 1.2 instead of 1.0 but thought I may as well mention it since @jswillard asked about updating |
I added two more commits removing the extraneous port version for |
The usage test passed on
|
If the suggest usage is:
then we need an explicit usage file. |
The usage test passed on
|
"dll.hpp" ) | ||
if(WIN32) | ||
set_target_properties(clamunrar PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON) | ||
+ target_sources( clamunrar PRIVATE "isnt.cpp") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you submit this patch upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream (1.2.1) is much ahead of this port (0.103.11) and has similar code since 1.0.
Cisco-Talos/clamav@e60843a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jswillard Would you like to update clamav
to the latest version 1.2.1
?
Is there any new progress? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jswillard still working on this? |
I'm not sure what work still needs to be done here. |
If the latest upstream version has a similar fix, reporting this patch to the upstream may not get a response.
OK, I understand what you mean and will mark it as |
* [json-c] update to version 0.17 2023-08-12 * [json-c] update version database * [clamav] update to version 0.103.11 * [clamav] update version db * [clamav] add patch to compile isnt.cpp on windows * [clamav] update version db * [clamav] remove extra port version * [clamav] update version db * fix cmakelists.txt * update version * fix cmakelists.txt * update git-tree * remove fix-cmakelists.patch * update git-tree * format * update git-tree --------- Co-authored-by: Monica <[email protected]>
./vcpkg x-add-version --all
and committing the result.