Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cppp-reiconv] new port #34263

Merged
merged 13 commits into from
Oct 28, 2023
Merged

[cppp-reiconv] new port #34263

merged 13 commits into from
Oct 28, 2023

Conversation

ChenPi11
Copy link
Contributor

@ChenPi11 ChenPi11 commented Oct 4, 2023 •
edited
Loading

If this PR adds a new port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@ChenPi11 ChenPi11 closed this Oct 5, 2023
@ChenPi11 ChenPi11 reopened this Oct 5, 2023
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 7, 2023
@Cheney-W Cheney-W marked this pull request as draft October 7, 2023 10:35
@Cheney-W
Copy link
Contributor

Cheney-W commented Oct 7, 2023

Moving the PR to draft. Please set it to "ready for review" once changes have been applied.

@ChenPi11 ChenPi11 marked this pull request as ready for review October 7, 2023 11:31
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2023
BillyONeal
BillyONeal previously requested changes Oct 10, 2023
View reviewed changes
ports/cppp-reiconv/portfile.cmake Show resolved Hide resolved
ports/cppp-reiconv/portfile.cmake Show resolved Hide resolved
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Oct 10, 2023
@BillyONeal BillyONeal marked this pull request as draft October 10, 2023 00:15
@ChenPi11 ChenPi11 marked this pull request as ready for review October 12, 2023 00:33
@Cheney-W
Copy link
Contributor

@BillyONeal Do you have any other questions about this PR?

@ChenPi11 ChenPi11 closed this Oct 24, 2023
@ChenPi11 ChenPi11 reopened this Oct 24, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Oct 25, 2023
@data-queue data-queue merged commit ab567f8 into microsoft:master Oct 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChenPi11 @Cheney-W @BillyONeal @data-queue