-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[krabsetw] Update to 4.3.1 #33640
[krabsetw] Update to 4.3.1 #33640
Conversation
@microsoft-github-policy-service agree |
An error occurred while testing usage, but was not caused by your PR, would you like to fix it? usage:
When testing usage, the following error occurs:
CMakeFindUsage.cpp#include <iostream> #include "krabs.hpp" CMakeLists.txtcmake_minimum_required (VERSION 3.8) |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
I apologize for late reply, I was out of town last week, I'll take a look and see if I can figure out the testing stage error this week |
Hi Monica, I've found the issue with the testing usage. It was missing the preprocessor definition for UNICODE that prevents it from building successfully (https://github.com/microsoft/krabsetw/blob/550f5edfdb6464567d7a618702316183d31746e5/krabs/README.md?plain=1#L5C15-L5C15). Adding |
Can you add a usage file which says that UNICODE needs to be on? See https://learn.microsoft.com/en-us/vcpkg/maintainers/handling-usage-files |
Actually nevermind this is just an update, thanks! |
The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.