Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tbb]: added support for hybrid processors via hwloc #31643

Merged
merged 2 commits into from
May 30, 2023
Merged

[tbb]: added support for hybrid processors via hwloc #31643

merged 2 commits into from
May 30, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented May 26, 2023 •
edited
Loading

With this patch we are adding support of hybrid processors (new tbbbind library is being built), so TBB can distinguish performance and efficient cores on both ARM and x64 processors.

Note: this applicable only for shared libraries built, because tbbbind library is built as plugin for TBB.

@Osyotr
Copy link
Contributor

Osyotr commented May 26, 2023

Maybe make it a feature? Also add "supports": "!static"

@ilya-lavrenov
Copy link
Contributor Author

Maybe make it a feature? Also add "supports": "!static"

done

@Osyotr
Copy link
Contributor

Osyotr commented May 26, 2023 •
edited
Loading

Hmm if there are no changes in protfile.cmake I assume tbb will link to hwloc even if installed separately. This is a bug in the port. Probably -DTBB_DISABLE_HWLOC_AUTOMATIC_SEARCH=ON/OFF needs to be passed depending on whether the feature is requested or not.

@ilya-lavrenov
Copy link
Contributor Author

Hmm if there are no changes in protfile.cmake I assume tbb will link to hwloc even if installed separately. This is a bug in the port. Probably -DTBB_DISABLE_HWLOC_AUTOMATIC_SEARCH=ON/OFF needs to be passed depending on whether the feature is requested or not.

great catch! Fixed according to your note.

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 29, 2023
@LilyWangLL
Copy link
Contributor

Feature passed on the following triplets:

x64-windows
x86-windows

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 29, 2023
@ilya-lavrenov
Copy link
Contributor Author

Can we merge the PR?

@dan-shaw dan-shaw merged commit 8905533 into microsoft:master May 30, 2023
@ilya-lavrenov ilya-lavrenov deleted the tbb branch May 30, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilya-lavrenov @Osyotr @LilyWangLL @dan-shaw