Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blake3] Update port to use official buildsystem #31602

Conversation

BurningEnlightenment
Copy link
Contributor

The blake3 library got a modern CMake buildsystem with target exports in BLAKE3-team/BLAKE3#304. This PR backports the official buildsystem to the old/current release.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BurningEnlightenment BurningEnlightenment force-pushed the dev/ports/blake3/update-buildsystem branch from d43ba16 to ecfd605 Compare May 24, 2023 09:23
@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 24, 2023
@BurningEnlightenment BurningEnlightenment marked this pull request as draft May 24, 2023 10:02
@BurningEnlightenment

This comment was marked as resolved.

@BurningEnlightenment BurningEnlightenment force-pushed the dev/ports/blake3/update-buildsystem branch from ecfd605 to d889623 Compare May 25, 2023 09:46
@BurningEnlightenment BurningEnlightenment marked this pull request as ready for review May 25, 2023 09:52
@BurningEnlightenment
Copy link
Contributor Author

@MonicaLiu0311 this is ready for review.

@MonicaLiu0311
Copy link
Contributor

The usage test passed (header files found):

blake3 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(blake3 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE BLAKE3::blake3)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label May 25, 2023
@dan-shaw dan-shaw merged commit 08d69d5 into microsoft:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants