[tracy] compatible with non wayland systems #31520
Conversation
BillyONeal
changed the title
|
This seems to reverse a decision upstream explicitly made, so I think you should be talking to them first... |
|
A lot of distros haven’t moved to wayland yet, I can change it to be an
option instead but I thought it was better that the default is the most
compatible one.
…On Sat, 20 May 2023 at 01:33, BillyONeal ***@***.***> wrote:
This seems to reverse a decision upstream explicitly made, so I think you
should be talking to them first...
—
Reply to this email directly, view it on GitHub
<#31520 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRISFYZMGZ2CJBKU26HP3XHAGPLANCNFSM6AAAAAAYH2274Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Cheney-W
added
the
category:port-feature
|
In general, it is advisable to follow the upstream design and seek their approval for any modifications made to the source code. Therefore, could you please communicate the current situation to the upstream project and seek their feedback? Thank you! |
|
But it's not a modification to the source code, it's just passing the option to target the old backed that works for more windowing systems than just wayland. GLFW works for wayland and x11 |
|
The modification to the code is the same vcpkg had for 0.9.0 before the upstream change just to make it use vcpkg imgui instead of the repo imgui |
|
To make it easier I just created gui-tools-legacy that builds the gui-tools with the legacy flag |
Just to verify: with this feature selected, the package supports x11 in addition to wayland, using a different implementation under the hood? |
|
Yes, with the initial version I submitted it supports wayland and x11 by
using glfw that supports both. The non legacy version is pure wayland.
…On Mon, 22 May 2023 at 18:29, Kai Pastor ***@***.***> wrote:
GLFW works for wayland and x11
To make it easier I just created gui-tools-legacy that builds the
gui-tools with the legacy flag
Just to verify: with this feature selected, the package supports x11 in
addition to wayland, using a different implementation under the hood?
—
Reply to this email directly, view it on GitHub
<#31520 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRISEAWQCFTDXNH4KTUGLXHOH7HANCNFSM6AAAAAAYH2274Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
All features test passed with below triplets: |
|
This is also against our features should not be alternatives policy, so I think we would recommend users to use port overlays in this case. |
|
That's why originally I just made glfw backend the default as it offers more compatibility. Upstream still offers as an option I don't understand why vcpkg can't make it the default |
This should be the reason why the legacy choice should be used in general for now: It supports new and old systems without needing overlays AFAIU. And this was originally proposed. |
|
Changed back to the original proposal |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tracy 0.9.1 makes Wayland the default backend for the gui tool but a lot of systems don't support it yet, switching back to glfw3 keeps it backward compatible