Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdcurses] Add export CMake config #31453

Merged
merged 10 commits into from
May 18, 2023

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented May 16, 2023

Fixes #11027, add export CMake config for pdcurses.
Usage test passed on x64-windows.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels May 16, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review May 16, 2023 02:33
ports/pdcurses/unofficial-pdcurses-config.cmake Outdated Show resolved Hide resolved
ports/pdcurses/vcpkg.json Outdated Show resolved Hide resolved
@Cheney-W Cheney-W marked this pull request as draft May 16, 2023 10:17
@dg0yt
Copy link
Contributor

dg0yt commented May 16, 2023

You applied my remark on the release variant, but this binary must exist. You need to apply it to the debug variant.

@LilyWangLL LilyWangLL requested a review from dg0yt May 17, 2023 07:51
@LilyWangLL LilyWangLL changed the title [pdcurses] Add export CMake config and update to latest commit [pdcurses] Add export CMake config May 17, 2023
@LilyWangLL LilyWangLL removed the category:port-update The issue is with a library, which is requesting update new revision label May 17, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review May 18, 2023 01:01
Cheney-W
Cheney-W previously approved these changes May 18, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 18, 2023
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Testing actual usage incl. linking is left to you.

(I would not deal with the DLL location in the config file. Just find_library and IMPORTED_LOCATION is enough, works across linkage and platforms, and is handled this way in similar find modules.)

@JavierMatosD JavierMatosD merged commit 40619a5 into microsoft:master May 18, 2023
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue11027 branch June 15, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do I use PDCurses after having installed it?
4 participants