-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdcurses] Add export CMake config #31453
[pdcurses] Add export CMake config #31453
Conversation
You applied my remark on the release variant, but this binary must exist. You need to apply it to the debug variant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Testing actual usage incl. linking is left to you.
(I would not deal with the DLL location in the config file. Just find_library
and IMPORTED_LOCATION
is enough, works across linkage and platforms, and is handled this way in similar find modules.)
Fixes #11027, add export CMake config for
pdcurses
.Usage test passed on
x64-windows
.The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.