Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fineftp] add new port fineftp-v1.3.4 #31435

Merged
merged 14 commits into from
May 16, 2023
Merged

Conversation

adolfos94
Copy link
Contributor

@adolfos94 adolfos94 commented May 15, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@adolfos94 adolfos94 changed the title Fineftp Fineftp v1.3.4 May 15, 2023
ports/fineftp/portfile.cmake Outdated Show resolved Hide resolved
ports/fineftp/portfile.cmake Outdated Show resolved Hide resolved
ports/fineftp/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814 Adela0814 changed the title Fineftp v1.3.4 [fineftp] add new port fineftb-v1.3.4 May 15, 2023
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 15, 2023
@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Adela0814 Adela0814 marked this pull request as draft May 15, 2023 03:02
@adolfos94 adolfos94 marked this pull request as ready for review May 15, 2023 03:43
@adolfos94 adolfos94 requested a review from Adela0814 May 15, 2023 03:43
ports/fineftp/portfile.cmake Outdated Show resolved Hide resolved
ports/fineftp/portfile.cmake Outdated Show resolved Hide resolved
@adolfos94 adolfos94 requested a review from Adela0814 May 15, 2023 21:18
@adolfos94 adolfos94 changed the title [fineftp] add new port fineftb-v1.3.4 [fineftp] add new port fineftp-v1.3.4 May 15, 2023
@Adela0814
Copy link
Contributor

Tested usage on x-64-windows, no feature needs to test.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label May 16, 2023
@JavierMatosD JavierMatosD merged commit 338d300 into microsoft:master May 16, 2023
@adolfos94 adolfos94 deleted the fineftp branch May 18, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants