-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libigl] Fix libigl features #31420
Merged
JavierMatosD
merged 11 commits into
microsoft:master
from
FabienPean:fix/libigl-features
May 17, 2023
Merged
[libigl] Fix libigl features #31420
JavierMatosD
merged 11 commits into
microsoft:master
from
FabienPean:fix/libigl-features
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienPean
force-pushed
the
fix/libigl-features
branch
from
May 13, 2023 13:33
a247b67
to
689fdb6
Compare
FabienPean
force-pushed
the
fix/libigl-features
branch
from
May 13, 2023 14:36
689fdb6
to
cc7f48f
Compare
FabienPean
force-pushed
the
fix/libigl-features
branch
from
May 13, 2023 14:42
cc7f48f
to
6e18480
Compare
FabienPean
force-pushed
the
fix/libigl-features
branch
from
May 13, 2023 14:46
6e18480
to
69ea3ef
Compare
LilyWangLL
added
the
category:port-bug
The issue is with a library, which is something the port should already support
label
May 15, 2023
LilyWangLL
previously approved these changes
May 15, 2023
Usage test pass on |
dg0yt
reviewed
May 15, 2023
LilyWangLL
removed
the
info:reviewed
Pull Request changes follow basic guidelines
label
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30621 C
Fixes #31168
Probably related
#31162
#30332
./vcpkg x-add-version --all
and committing the result.For some reason the usage on Windows was
find_package(Libigl)
(note the uppercase L) while on codespace under Linux I got away with and without the capitalized package name,Simple example (tested on x64-windows) involving embree, opengl, glfw, imgui, xml:
mwe_igl.zip
Also tested on x64-windows with a cgal example