Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libigl] Fix libigl features #31420

Merged
merged 11 commits into from
May 17, 2023

Conversation

FabienPean
Copy link
Contributor

@FabienPean FabienPean commented May 12, 2023

Fixes #30621 C
Fixes #31168
Probably related
#31162
#30332

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
  • libigl does not install and export any targets beside igl_core by default, hence the patch
  • The license is updated to reflect more closely upstream. The library is mostly under MPL2, only the copyless folder is under GPL which is bounded to specific "igl_copyleft_*" targets

For some reason the usage on Windows was find_package(Libigl) (note the uppercase L) while on codespace under Linux I got away with and without the capitalized package name,

Simple example (tested on x64-windows) involving embree, opengl, glfw, imgui, xml:
mwe_igl.zip
Also tested on x64-windows with a cgal example

@FabienPean FabienPean marked this pull request as ready for review May 12, 2023 22:16
@FabienPean FabienPean marked this pull request as draft May 12, 2023 22:49
@FabienPean FabienPean marked this pull request as ready for review May 13, 2023 17:34
@LilyWangLL LilyWangLL self-assigned this May 15, 2023
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label May 15, 2023
LilyWangLL
LilyWangLL previously approved these changes May 15, 2023
@LilyWangLL
Copy link
Contributor

Usage test pass on x64-windows.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 15, 2023
ports/libigl/vcpkg.json Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label May 15, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 17, 2023
@JavierMatosD JavierMatosD merged commit 221670a into microsoft:master May 17, 2023
@FabienPean FabienPean deleted the fix/libigl-features branch May 23, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libigl[cgal]] missing headers [libigl] v2.4.0 broken due to port and upstream problems
4 participants