Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bshoshany-thread-pool] Updated to v3.4.0 #31418

Merged
merged 2 commits into from
May 16, 2023

Conversation

bshoshany
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Thanks!

Adela0814
Adela0814 previously approved these changes May 15, 2023
@Adela0814
Copy link
Contributor

@bshoshany Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@bshoshany
Copy link
Contributor Author

Thanks! I accepted your changes, but now it's failing a check :(

@bshoshany bshoshany marked this pull request as ready for review May 15, 2023 03:03
@Adela0814 Adela0814 marked this pull request as draft May 15, 2023 06:55
@bshoshany bshoshany marked this pull request as ready for review May 15, 2023 14:54
@bshoshany
Copy link
Contributor Author

I removed the line you indicated, but it's still failing a check - although maybe I didn't understand what you wanted me to change. Perhaps we should just revert to the original version? Thanks.

@Adela0814
Copy link
Contributor

Adela0814 commented May 16, 2023

@bshoshany The CI error was reported because the SHA value is incorrect. After making the changes, you should run the command again to update the SHA: \vcpkg.exe x-add-version bshoshany-thread-pool --overwrite-version.

@bshoshany
Copy link
Contributor Author

In the end I decided to just revert to my original version, since unfortunately I don't have more time to devote to this PR. I will incorporate the REF "v${VERSION}" trick next time I update the package. Thanks again :)

@bshoshany bshoshany marked this pull request as ready for review May 16, 2023 02:24
@bshoshany bshoshany requested a review from Adela0814 May 16, 2023 02:25
@Adela0814 Adela0814 added category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines labels May 16, 2023
@JavierMatosD JavierMatosD merged commit 429c605 into microsoft:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants