-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bshoshany-thread-pool] Updated to v3.4.0 #31418
Conversation
@bshoshany Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags. |
Thanks! I accepted your changes, but now it's failing a check :( |
I removed the line you indicated, but it's still failing a check - although maybe I didn't understand what you wanted me to change. Perhaps we should just revert to the original version? Thanks. |
@bshoshany The CI error was reported because the SHA value is incorrect. After making the changes, you should run the command again to update the SHA: |
In the end I decided to just revert to my original version, since unfortunately I don't have more time to devote to this PR. I will incorporate the |
./vcpkg x-add-version --all
and committing the result.Thanks!