Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][binlog] disable performance tests #31410

Merged
merged 4 commits into from
May 13, 2023

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented May 12, 2023

Fixes vcpkg pipeline issue binlog:x64-linux installation failed with following error:
https://dev.azure.com/vcpkg/public/_build/results?buildId=89371&view=results

/mnt/vcpkg-ci/buildtrees/binlog/src/67e0b185a6-9b5f7f266f.clean/test/perf/PerftestQueue.cpp: In function ‘void {anonymous}::doNotOptimizeBuffer(const char*, std::size_t)’:
/mnt/vcpkg-ci/buildtrees/binlog/src/67e0b185a6-9b5f7f266f.clean/test/perf/PerftestQueue.cpp:18:36: error: ‘typename std::enable_if<(std::is_trivially_copyable<_Tp>::value && (sizeof (Tp) <= sizeof (Tp*)))>::type benchmark::DoNotOptimize(const Tp&) [with Tp = char; typename std::enable_if<(std::is_trivially_copyable<_Tp>::value && (sizeof (Tp) <= sizeof (Tp*)))>::type = void]’ is deprecated: The const-ref version of this method can permit undesired compiler optimizations in benchmarks [-Werror=deprecated-declarations]
   18 |     benchmark::DoNotOptimize(buf[i]);
      |

For vcpkg, we don't need binlog to build performance tests. Even though we found benchmark. https://github.com/morganstanley/binlog/blob/3fef8846f5ef98e64211e7982c2ead67e0b185a6/CMakeLists.txt#L387

find_package(benchmark COMPONENTS benchmark)

if (benchmark_FOUND)

 message(STATUS "Build performance tests")

 function(add_benchmark name)
   add_executable(${name} test/perf/${name}.cpp)
   target_link_libraries(${name} headers)
   target_link_libraries(${name} benchmark::benchmark)
 endfunction()

 add_benchmark(PerftestQueue)
 add_benchmark(PerftestSessionWriter)

else ()
 message(STATUS "Google Benchmark library not found, will not build performance tests")
endif ()
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 12, 2023
@FrankXie05 FrankXie05 marked this pull request as ready for review May 12, 2023 06:06
ports/binlog/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 12, 2023
@JavierMatosD JavierMatosD merged commit 72116f0 into microsoft:master May 13, 2023
@FrankXie05 FrankXie05 deleted the dev/Frank/baseline-binlog branch May 15, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants