Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ltla-umappp|ltla-*] new ports #31397

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

moritz-h
Copy link
Contributor

This adds the port ltla-umappp and all required dependencies. I included them in a single PR, because all 6 libraries are using the same project layout, same CMake handling, are all header only and overall relative small libraries without any patches or other edge cases and have many dependencies on each other. I assume reviewing will be very similar for all of them, so maybe it is easier to look at them at once. However, if you want a single port per PR I could split it up.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 12, 2023
@Adela0814
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Adela0814
Copy link
Contributor

Testing usages.

@Adela0814
Copy link
Contributor

Testing usages.

Tested usage on x64-windows.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label May 12, 2023
@JavierMatosD JavierMatosD merged commit 9f0d3d4 into microsoft:master May 13, 2023
@moritz-h moritz-h deleted the umappp branch May 13, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants