Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow] Update to 12.0.0 #31321

Merged
merged 2 commits into from
May 10, 2023
Merged

[arrow] Update to 12.0.0 #31321

merged 2 commits into from
May 10, 2023

Conversation

raulcd
Copy link
Contributor

@raulcd raulcd commented May 8, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@raulcd
Copy link
Contributor Author

raulcd commented May 8, 2023

sorry, I force pushed again because I forgot to remove the plasma feature due to the removal. If someone can run the workflows again.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label May 9, 2023
@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:

x86-windows
x64-windows

The usage test passed (header files found):

The package arrow provides CMake targets:

    find_package(Arrow CONFIG REQUIRED)
    target_link_libraries(main PRIVATE "$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Arrow::arrow_static,Arrow::arrow_shared>")

    find_package(Parquet CONFIG REQUIRED)
    target_link_libraries(main PRIVATE "$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Parquet::parquet_static,Parquet::parquet_shared>")

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label May 10, 2023
@JavierMatosD
Copy link
Contributor

sorry, I force pushed again because I forgot to remove the plasma feature due to the removal. If someone can run the workflows again.

Hi @raulcd, could you clarify why you want to remove the plasma feature and add the acero feature?

I'll be moving the PR to draft status while you response. Please mark it ready for review once you've replied so that I can see you've responded.

@JavierMatosD JavierMatosD marked this pull request as draft May 10, 2023 18:23
@raulcd
Copy link
Contributor Author

raulcd commented May 10, 2023

hi @JavierMatosD

Plasma was removed on the 12.0.0 release: apache/arrow#33243
Acero has been moved out of libarrow into it’s own shared library, allowing for smaller builds of the core libarrow on the 12.0.0 release: apache/arrow#15280

See the release notes for 12.0.0 for more details: https://arrow.apache.org/blog/2023/05/02/12.0.0-release/

@raulcd
Copy link
Contributor Author

raulcd commented May 10, 2023

As you can see doing that was also discussed on the dev mailing list for Apache Arrow as part of the release post tasks: https://lists.apache.org/thread/68kcovy7bnhz19mn1jvwcwpxy29kxn03

@raulcd raulcd marked this pull request as ready for review May 10, 2023 19:10
@JavierMatosD JavierMatosD merged commit 281cfd3 into microsoft:master May 10, 2023
@davesworking
Copy link

davesworking commented May 17, 2023

FindArrowAcero.cmake is not being generated. Should it be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants