-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vsg] New port (VulkanSceneGraph) #31300
Conversation
The pipeline isn't particularly useful since it skips the
I do not have the ability to test this on ARM or macOS, however. |
Related issue: #28529 |
The usage has been tested successfully locally.
|
ports/vsg/portfile.cmake
Outdated
|
||
vcpkg_cmake_configure( | ||
SOURCE_PATH "${SOURCE_PATH}" | ||
DISABLE_PARALLEL_CONFIGURE #parallel build interferes with cloning glslang in vsg's CMake script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stumbled over this comment and checked upstream.
https://github.com/vsg-dev/VulkanSceneGraph/blob/f02eba66c8f37e689912363ebd7b9bb79453a8fd/CMakeLists.txt#L40-L63
I think this needs work if you don't want to turn off VSG_SUPPORTS_ShaderCompiler
.
git clone
depends on availability of the git tool and bypasses asset caching.- The clone repo is another fork of what vcpkg offers with port
glslang
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's a bit of a problematic aspect of the project. It would be preferable not to disable the shader compiler, but the project vendors its own fork of glslang that might be troublesome to untangle. I will attempt to make it use the vcpkg-provided dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it was relatively simple. There were only a few minor changes needed to get vsg to compile with the version of glslang provided by vcpkg. I don't observe any compile issues with the latest commit on any of the triplets I mentioned previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VulkanSceneGraph project lead here, as a heads up we are experimenting with moving the glslang dependency out from being a insource build to a standard 3rd party dependency. There's a whole tangled web of issue with linking to glslang previously forcing us to resort to the insource build, but slowly it looks like it's distribution is become more standardized so fingers crossed we'll be able to make glslang an external dependency.
I've written up this work on the VSG discussion forum: vsg-dev/VulkanSceneGraph#1199
The work can be found in the external_glslang branch: https://github.com/vsg-dev/VulkanSceneGraph/tree/external_glslang
Once we've seen a bit more cross platform testing I'll merged the external_glslang branch with VSG master and tag a developer release 1.1.5, then eventually we'll get to a 1.2.0 stable release in the next couple of months.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.