Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ocilib] does support non windows arm #31295

Merged
merged 1 commit into from
May 11, 2023
Merged

[ocilib] does support non windows arm #31295

merged 1 commit into from
May 11, 2023

Conversation

autoantwort
Copy link
Contributor

Tested on arm64-osx

@LilyWangLL LilyWangLL self-assigned this May 8, 2023
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 8, 2023
@LilyWangLL
Copy link
Contributor

LilyWangLL commented May 8, 2023 •
edited
Loading

Please also remove the following codes from ci.baseline.txt.

ocilib:arm-uwp=fail
ocilib:arm64-windows=fail
ocilib:x64-uwp=fail

I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@LilyWangLL LilyWangLL marked this pull request as draft May 8, 2023 03:06
@autoantwort autoantwort marked this pull request as ready for review May 10, 2023 01:53
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2023
@JavierMatosD JavierMatosD merged commit 35ffca6 into microsoft:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @LilyWangLL @JavierMatosD