Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[behaviortree-cpp] Update to 4.1.1 #31287

Merged

Conversation

MonicaLiu0311
Copy link
Contributor

Fixes #31192.

  • Update behaviortree-cpp to 4.1.1.
  • Removed outdated patches 001_port_fixes.patch and 002_fix_dependencies.patch.
  • The new version supports building dynamic libraries, see upstream: CMakeLists.txt#L150-L155
  • Two errors occurred when building for x86-windows as follows, adding fix-x86_build.patch to fix it. Reported upstream: BehaviorTree.CPP/issues/555
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp\utils\simple_string.hpp(128): error C2589: '(': illegal token on right side of '::'
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp\utils\simple_string.hpp(128): error C2062: type 'unknown-type' unexpected
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp\utils\simple_string.hpp(128): error C2789: 'SafeAny::SimpleString::CAPACITY': an object of const-qualified type must be initialized
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp\utils\simple_string.hpp(128): error C2059: syntax error: ')'
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp\utils\simple_string.hpp(136): error C2131: expression did not evaluate to a constant
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp\utils\simple_string.hpp(157): error C3863: array type 'char [CAPACITY]' is not assignable
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp/utils/convert_impl.hpp(68): error C2760: syntax error: '(' was unexpected here; expected ')'
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\include\behaviortree_cpp/utils/convert_impl.hpp(68): error C3878: syntax error: unexpected token '(' following 'expression'
    
    E:\vcpkg01\buildtrees\behaviortree-cpp\src\haviorTree-00e1cfa921.clean\3rdparty\lexy\include\lexy/_detail/swar.hpp(144): error C3861: '_BitScanForward64': identifier not found
    
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

No feature needs to be tested. The usage test passed (header files found):

behaviortree-cpp provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(behaviortree_cpp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE BT::behaviortree_cpp)

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels May 6, 2023
@MonicaLiu0311 MonicaLiu0311 added depends:upstream-changes Waiting on a change to the upstream project and removed depends:upstream-changes Waiting on a change to the upstream project labels May 6, 2023
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review May 10, 2023 10:17
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2023
@JavierMatosD JavierMatosD merged commit 3256b18 into microsoft:master May 11, 2023
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/update_behaviortree-cpp branch May 12, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[behaviortree-cpp] update to 4.1.1
3 participants