Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microsoft-signalr] Fix usage issue #31286

Merged
merged 1 commit into from
May 9, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented May 6, 2023

Fixes #30998

Usage test passed with following triplets:
x64-windows
x86-windows-static

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 6, 2023
@Cheney-W Cheney-W marked this pull request as ready for review May 6, 2023 09:39
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2023
@vicroms vicroms merged commit c8b9f10 into microsoft:master May 9, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/30998 branch May 9, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[microsoft-signalr] build failure
3 participants