-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdal, pdal-c] Update to v2.5.3, v2.2.0 and fix GCC 13 build #31257
Conversation
The following error occurs during CI testing:
D:\buildtrees\pdal\config-x64-windows-out.log:
Note: I will be converting your PR to draft status. When you resolve, revert to "ready for review". That way, I know you've fixed it, since you can't modify the tags. |
That error is expected until the mentioned PR for Draco is merged, which does unfortunately prevent the pipeline from running successfully. I will mark this for review once the Draco PR has been merged. |
PDAL's C API must also be updated to version 2.2.0 to account for an API change in PDAL. I have added the required update to pdal-c to this PR. |
Usage:
When testing usage, the following error occurs:
|
All features are tested successfully in the following triplet:
The usage test passed (header files found):
|
./vcpkg x-add-version --all
and committing the result.This updates PDAL to version 2.5.3, and includes a PR that fixes a build error with GCC 13. The GCC 8 compatibility patch was removed as it has been accepted into the upstream repo.
PDAL 2.5.3 depends on Draco 1.5.6. An existing PR to upgrade Draco exists at #31220