Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-cpp] Fixes #31218 #31219

Merged
merged 1 commit into from
May 4, 2023

Conversation

klalumiere
Copy link
Contributor

Fixes #31218

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label May 4, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passed(header files found):

opentelemetry-cpp provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(opentelemetry-cpp CONFIG REQUIRED)
    # note: 9 additional targets are not displayed.
    target_link_libraries(main PRIVATE opentelemetry-cpp::api opentelemetry-cpp::ext opentelemetry-cpp::sdk opentelemetry-cpp::logs)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label May 4, 2023
@JavierMatosD JavierMatosD merged commit c0b1007 into microsoft:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry-cpp] build failure (Unknown CMake command "find_dependency")
3 participants