Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libsbml] Update to 5.20.0 #31149

Merged
merged 10 commits into from
May 10, 2023
Merged

[libsbml] Update to 5.20.0 #31149

merged 10 commits into from
May 10, 2023

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Apr 27, 2023 •
edited
Loading

Update libsbml to 5.20.0, the latest version of libsbml has deprecated function unary_function, fix the build error in an internal version of Visual Studio test:

D:\buildtrees\libsbml\src\9d979ecb20-022ca53869.clean\src\sbml\SBO.cpp(195): error C2504: 'unary_function': base class undefined
D:\buildtrees\libsbml\src\9d979ecb20-022ca53869.clean\src\sbml\SBO.cpp(195): error C2143: syntax error: missing ',' before '<'
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

Usage test pass with following triplets:

x64-windows
x64-windows-static

@LilyWangLL LilyWangLL added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Apr 27, 2023
dg0yt
dg0yt suggested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CMake config files, we must be careful. It is driven by calls to find_package.
In particular...

ports/libsbml/libsbml-config.cmake Outdated Show resolved Hide resolved
ports/libsbml/libsbml-config.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL marked this pull request as ready for review May 8, 2023 05:53
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 8, 2023
vicroms
vicroms previously requested changes May 9, 2023
View reviewed changes
ports/libsbml/fix-cmake.patch Outdated Show resolved Hide resolved
@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label May 9, 2023
@LilyWangLL LilyWangLL marked this pull request as draft May 9, 2023 09:35
@LilyWangLL LilyWangLL marked this pull request as ready for review May 10, 2023 07:20
@LilyWangLL LilyWangLL requested a review from vicroms May 10, 2023 07:20
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 10, 2023
@JavierMatosD JavierMatosD merged commit b049e49 into microsoft:master May 10, 2023
@LilyWangLL LilyWangLL deleted the dev/LilyWang/Update_libsbml branch June 15, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt requested changes

@Cheney-W Cheney-W Cheney-W approved these changes

@vicroms vicroms Awaiting requested review from vicroms

Assignees

@Cheney-W Cheney-W

Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LilyWangLL @vicroms @dg0yt @Cheney-W @JavierMatosD