Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-base] GLU is not required #31148

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Apr 27, 2023

The only mention of GLU in Qt5 is in Qt wiki which was probably not updated since Qt4.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

message(WARNING "qt5-base currently requires some packages from the system package manager. "
"They can be installed on Ubuntu systems via "
"sudo apt-get install '^libxcb.*-dev' libx11-xcb-dev libglu1-mesa-dev libxrender-dev "
"sudo apt-get install '^libxcb.*-dev' libx11-xcb-dev libgl1-mesa-dev libxrender-dev "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be libglvnd nowadays ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to read more about the topic. From what I learned libGL.so in modern systems is just a wrapper for libGLdispatch.so so using former gives more compatibility.
PS: there's similar message in qtbase which should probably also be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but how am I supposed to deploy an app that links to libGLdispatch.so? Shouldn't it come from system?

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 27, 2023
@JavierMatosD JavierMatosD merged commit cdc9529 into microsoft:master May 1, 2023
@Osyotr Osyotr deleted the qt5-glu branch May 2, 2023 04:24
@Osyotr Osyotr mentioned this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants