Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libjpeg-turbo] Update usage #31071

Merged
merged 2 commits into from
Apr 26, 2023
Merged

[libjpeg-turbo] Update usage #31071

merged 2 commits into from
Apr 26, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 23, 2023

Implements #30769 (comment).
Fixes #30696.
Alternative to #30769.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt mentioned this pull request Apr 23, 2023
Closed
7 tasks
@LilyWangLL LilyWangLL self-assigned this Apr 24, 2023
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Apr 24, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 24, 2023
@LilyWangLL
Copy link
Contributor

LilyWangLL commented Apr 24, 2023 •
edited
Loading

This PR just modify the usage file, I canceled the arm64_windows run on CI pipeline, and the x64-linux error on CI pipeline are not related with this PR, it will be fixed in PR #31048

@BillyONeal BillyONeal merged commit 017bd3f into microsoft:master Apr 26, 2023
@BillyONeal
Copy link
Member

Thanks for the updated usage and following through the other two related PRs!

@dg0yt dg0yt deleted the libjpeg-turbo branch April 26, 2023 07:11
@daschuer daschuer mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libjpeg-turbo] find_package(JPEG REQUIRED) cannot find libturbojpeg.a
3 participants
@dg0yt @LilyWangLL @BillyONeal