-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quantlib] update to v1.30 #30985
[quantlib] update to v1.30 #30985
Conversation
Hi @Adela0814 can you share the CMake error logs with me? I can't see the underlying build failure from the pipeline logs so it's a bit hard to know why the builds failed. |
CI failure logs are in the public artifacts: |
Hmm, the links on that page are not working for me. @dg0yt if the links work for you, then would you mind pasting the underlying build error here for me? |
The downloads are hidden behind a three dots icon appearing on the right side when you hover an item. |
Aha, thanks! I found out the reason for the build failures now and I will fix it soon. |
I added a patch and now all checks have passed so I think this can be merged. I'll try to fix the upstream issue and remove the patch for the next version update. |
I see commits upstream from @sweemer so I'm happy saying they are a representative of upstream and thus no cooldown period is necessary. Thanks for the update/patch! |
./vcpkg x-add-version --all
and committing the result.