Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quantlib] update to v1.30 #30985

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

sweemer
Copy link
Contributor

@sweemer sweemer commented Apr 20, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 21, 2023
@sweemer
Copy link
Contributor Author

sweemer commented Apr 24, 2023

Hi @Adela0814 can you share the CMake error logs with me? I can't see the underlying build failure from the pipeline logs so it's a bit hard to know why the builds failed.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 24, 2023

@sweemer
Copy link
Contributor Author

sweemer commented Apr 24, 2023

Hmm, the links on that page are not working for me. @dg0yt if the links work for you, then would you mind pasting the underlying build error here for me?

@dg0yt
Copy link
Contributor

dg0yt commented Apr 24, 2023

The downloads are hidden behind a three dots icon appearing on the right side when you hover an item.

@sweemer
Copy link
Contributor Author

sweemer commented Apr 25, 2023

Aha, thanks!

I found out the reason for the build failures now and I will fix it soon.

@sweemer
Copy link
Contributor Author

sweemer commented Apr 26, 2023

I added a patch and now all checks have passed so I think this can be merged.

I'll try to fix the upstream issue and remove the patch for the next version update.

@BillyONeal
Copy link
Member

I see commits upstream from @sweemer so I'm happy saying they are a representative of upstream and thus no cooldown period is necessary.

Thanks for the update/patch!

@BillyONeal BillyONeal merged commit c651988 into microsoft:master Apr 26, 2023
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Apr 26, 2023
@sweemer sweemer deleted the quantlib-v1.30 branch April 26, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants