-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdl1-mixer] new port #30921
[sdl1-mixer] new port #30921
Conversation
@microsoft-github-policy-service agree |
c802f94
to
4175431
Compare
b2fac9b
to
ac10474
Compare
It looks like this is a complete build system replacement. Is there a specific reason the replacement is done with msbuild rather than with something like cmake? I'm nervous about this replacement not being stable across updates. |
I assumed the sdl1 port would be a good example. but if cmake is preferred I can look into that. |
"copied from this other port" is a reasonable justification. This works, so I'm going to merge it as is, but would really appreciate CMake instead where possible. Thanks! |
IMO there are many old ports which are not good examples... |
Current github version, with custom msbuild files as with the sdl1 port and dependencies from vcpkg.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.