Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl1-mixer] new port #30921

Merged
merged 16 commits into from
Apr 21, 2023
Merged

[sdl1-mixer] new port #30921

merged 16 commits into from
Apr 21, 2023

Conversation

arbruijn
Copy link
Contributor

@arbruijn arbruijn commented Apr 17, 2023

Current github version, with custom msbuild files as with the sdl1 port and dependencies from vcpkg.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@arbruijn
Copy link
Contributor Author

@microsoft-github-policy-service agree

@arbruijn arbruijn force-pushed the sdl1-mixer branch 2 times, most recently from c802f94 to 4175431 Compare April 17, 2023 18:17
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 18, 2023
@arbruijn arbruijn marked this pull request as ready for review April 18, 2023 10:46
@arbruijn arbruijn marked this pull request as draft April 18, 2023 14:43
@arbruijn arbruijn force-pushed the sdl1-mixer branch 2 times, most recently from b2fac9b to ac10474 Compare April 18, 2023 15:03
@arbruijn arbruijn marked this pull request as ready for review April 18, 2023 15:35
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 20, 2023
@BillyONeal
Copy link
Member

It looks like this is a complete build system replacement. Is there a specific reason the replacement is done with msbuild rather than with something like cmake? I'm nervous about this replacement not being stable across updates.

@arbruijn
Copy link
Contributor Author

I assumed the sdl1 port would be a good example. but if cmake is preferred I can look into that.

@BillyONeal
Copy link
Member

I assumed the sdl1 port would be a good example. but if cmake is preferred I can look into that.

"copied from this other port" is a reasonable justification. This works, so I'm going to merge it as is, but would really appreciate CMake instead where possible.

Thanks!

@BillyONeal BillyONeal merged commit bb53a07 into microsoft:master Apr 21, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Apr 22, 2023

IMO there are many old ports which are not good examples...
This msbuild stuff makes it hard for non-MSVC users to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants