[qttools] copy traget tools only if they exists. #30442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Mar 26, 2023
ports/qttools/portfile.cmake
Outdated
Comment on lines
95
to
99
| set(OSX_APP_FOLDERS Designer.app Linguist.app pixeltool.app) | ||
| set(OSX_APP_FOLDERS Designer.app Linguist.app pixeltool.app qdbusviewer.app) | ||
| if (FEATURE_qdbus) | ||
| message(STATUS "Built qdbusviewer") | ||
| list(APPEND OSX_APP_FOLDERS qdbusviewer.app) | ||
| endif() |
There was a problem hiding this comment.
qdbusviewer is already added, subject to a condition.
FrankXie05
added
the
category:port-bug
They do not exist if you crosscompile qt
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
FrankXie05
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They do not exist if you crosscompile qt.
This fixes the build error that happens here when using an arm64-osx triplet on an x64-osx host:
https://github.com/daschuer/vcpkg/actions/runs/4476393103/jobs/7866710248
./vcpkg x-add-version --alland committing the result.