-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lunasvg] Add usage #30196
[lunasvg] Add usage #30196
Conversation
Does this config help with any usage requirements beyond what documenting |
@dg0yt, Thanks for your review, what exactly are you worthy of meeting any other requirements? I just checked locally whether the files generated under its |
I didn't claim it wouldn't be working. With regard to transitive usage requirements, I found only the following: C++ linkage, libm for non-windows. With regard to upstream, sammycage/lunasvg#84 may need support. |
Thanks for taking a look at this port Please consider also updating to the latest commit. The current version is outdated and lacks critical patches Like UB fix sammycage/lunasvg#123 and much more Thanks again |
Sorry to rush things but, could we merge this? |
The upstream issues were caused by build-internal changes, not by the exported config. |
I have commit a PR for Upstream sammycage/lunasvg#132 |
I submitted a PR upstream, but there has been no response for a month and a half, I think we can merge this PR first for users to use. |
}, | ||
{ | ||
"git-tree": "bf20380ca537151f7d1e02a6ca5b19c302db18c7", | ||
"version": "2.3.1", | ||
"port-version": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #32510 Deleted the historical "git-tree" when updating lunasvg, I restore it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops 😳. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, thanks for the fix!
Thanks! |
Thanks for merging fast! |
Fixes #30186
Lunasvg does not export anything after installation, I add the usage.
Tested the usage successfully by
lunasvg:x64-windows
:SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file../vcpkg x-add-version --all
and committing the result.