-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nettle] Switch from yasm to clang #30175
Conversation
Now CCAS clang is also used during configure, but stumbles over |
gmp has ASMFLAGS for that instead of cflags |
Building successfully now. Anyone out there who can validate the usability of the binary artifacts? |
ports/gmp/portfile.cmake
Outdated
@@ -43,6 +43,10 @@ if(VCPKG_TARGET_IS_WINDOWS AND NOT VCPKG_TARGET_IS_MINGW) | |||
) | |||
endif() | |||
|
|||
if(VCPKG_TARGET_IS_ANDROID AND VCPKG_TARGET_ARCHITECTURE STREQUAL "x86") | |||
vcpkg_list(APPEND OPTIONS "CFLAGS=\$CFLAGS -m32") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found during x86 tests of nettle with the NDK's clang on linux host. To be removed from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That flag has to come from the toolchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But from which point in the toolchain setup?
I took the -m32
from https://developer.android.com/ndk/guides/abis#x86, but I didn't find it in the NDK's or CMake's Android toolchain initialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and I also had to add -m32
to nettle's ASMFLAGS for clang-cl x86
string(APPEND asmflags " --target=x86_64-pc-windows-msvc") | ||
elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "arm64") | ||
string(APPEND asmflags " --target=arm64-pc-windows-msvc") | ||
else() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, no asm for arm-uwp
c676893
to
1016795
Compare
All features are tested successfully in the following triplet:
|
./vcpkg x-add-version --all
and committing the result.