Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zstd] Fix clang-cl flags #29992

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Conversation

Neumann-A
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 3, 2023
ports/zstd/fix-clang-cl.diff Outdated Show resolved Hide resolved
@Neumann-A
Copy link
Contributor Author

@FrankXie05 Is there a reason this is not getting reviewed ?

FrankXie05
FrankXie05 previously approved these changes Apr 11, 2023
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Apr 11, 2023
@BillyONeal
Copy link
Member

Thanks!

@BillyONeal BillyONeal merged commit 2c84b1e into microsoft:master Apr 13, 2023
@Neumann-A Neumann-A deleted the fix-zstd-clang-cl branch April 13, 2023 19:24
@daschuer daschuer mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants