Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraw] Update to 0.21.1, revise dependencies #29647

Merged
merged 9 commits into from
Feb 16, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 14, 2023

Follow-up from #29605, #29598 by @aklemets (original work included).
Closes #16267.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Feb 14, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/freeimage/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libraw/vcpkg.json

Valid values for the license field can be found in the documentation

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 14, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 15, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libraw/vcpkg.json

Valid values for the license field can be found in the documentation

@dg0yt dg0yt marked this pull request as ready for review February 15, 2023 08:34
@dg0yt dg0yt changed the title [libraw] Update, revise dependencies [libraw] Update to 0.21.1, revise dependencies Feb 15, 2023
@@ -1,7 +1,6 @@
{
"name": "libraw",
"version-string": "201903",
"port-version": 10,
"version": "0.21.1",
"description": "raw image decoder library",
"homepage": "https://www.libraw.org",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add license for libraw, thanks.

@Adela0814 Adela0814 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Feb 15, 2023
github-actions[bot]
github-actions bot previously approved these changes Feb 15, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/libraw/vcpkg.json (has deprecated license LGPL-2.1)

Deprecated and non deprecated license identifiers can be found here

Adela0814
Adela0814 previously approved these changes Feb 16, 2023
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Feb 16, 2023
@dg0yt dg0yt dismissed stale reviews from Adela0814 and github-actions[bot] via e0fcc9d February 16, 2023 05:37
@JavierMatosD JavierMatosD merged commit 2e3b958 into microsoft:master Feb 16, 2023
@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 17, 2023

Thanks @aklemets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libraw] update to snapshot 202101
4 participants