-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeimage] Updated port to prepare for libraw version 0.21 #29605
Closed
Closed
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e3be949
[freeimage] Updated port to prepare for libraw version 0.21
aklemets 0f4494c
Update baseline
aklemets cf6c639
Simpler build fix
aklemets ce9bc08
Updated the hash of latest freeimage changees
aklemets 413d8f3
Make it possible to use substream
aklemets 1c8f952
Updated freeimage port hash
aklemets 4b5cb4f
Add comment and simplify patch
aklemets 92d9a5f
Updated freeimage port hash
aklemets 2cb660c
Remove const declaration
aklemets 5493303
Updated freeimage port hash
aklemets 01fea71
Someone asked me to make changes to the portfile on their behalf
aklemets 0db2c76
Updated freeimage port hash
aklemets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
diff --git a/Source/FreeImage/PluginRAW.cpp b/Source/FreeImage/PluginRAW.cpp | ||
index c7f8758a..a57fd5f1 100644 | ||
--- a/Source/FreeImage/PluginRAW.cpp | ||
+++ b/Source/FreeImage/PluginRAW.cpp | ||
@@ -46,6 +46,14 @@ private: | ||
long _eof; | ||
INT64 _fsize; | ||
|
||
+ // Minimal change to make version 3.18.0 of FreeImage compile with | ||
+ // LibRaw 0.20 and later versions. | ||
+ // Once the port of FreeImage has been updated to a version greater | ||
+ // than 3.18.0, this patch should be removed as it will not be needed. | ||
+#if LIBRAW_COMPILE_CHECK_VERSION_NOTLESS(0, 20) | ||
+ LibRaw_abstract_datastream const *substream = nullptr; | ||
+#endif | ||
+ | ||
public: | ||
LibRaw_freeimage_datastream(FreeImageIO *io, fi_handle handle) : _io(io), _handle(handle) { | ||
long start_pos = io->tell_proc(handle); | ||
@@ -694,7 +702,11 @@ Load(FreeImageIO *io, fi_handle handle, int page, int flags, void *data) { | ||
// -------------------------------------------- | ||
|
||
// (-s [0..N-1]) Select one raw image from input file | ||
+#if LIBRAW_COMPILE_CHECK_VERSION_NOTLESS(0, 20) | ||
+ RawProcessor->imgdata.rawparams.shot_select = 0; | ||
+#else | ||
RawProcessor->imgdata.params.shot_select = 0; | ||
+#endif | ||
// (-w) Use camera white balance, if possible (otherwise, fallback to auto_wb) | ||
RawProcessor->imgdata.params.use_camera_wb = 1; | ||
// (-M) Use any color matrix from the camera metadata. This option only affects Olympus, Leaf, and Phase One cameras. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record the
const
was meant to come after the*
: A const pointer, not a pointer to const.