Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow] Update Arrow to 9.0.0 #26187

Merged
merged 7 commits into from
Aug 16, 2022
Merged

Conversation

assignUser
Copy link
Contributor

@assignUser assignUser commented Aug 5, 2022

Arrow 9.0.0 was just released this PR:

no changes

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Aug 5, 2022

CLA assistant check
All CLA requirements met.

@diehard2
Copy link

diehard2 commented Aug 5, 2022

would it be possible to verify your update fixes this issue?

#22552

As far as I can tell if one wants to use parquet, vcpkg doesn't work

@assignUser
Copy link
Contributor Author

@diehard2 I'll check :)

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 8, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 8, 2022
@assignUser
Copy link
Contributor Author

assignUser commented Aug 12, 2022

I successfully ran vcpkg install arrow[dataset,flight,json,mimalloc,s3]:x64-windows(-static)? and the Dockerfile from #22552
cc: @GPSnoopy @jgiannuzzi

@assignUser assignUser marked this pull request as ready for review August 12, 2022 16:35
github-actions[bot]
github-actions bot previously approved these changes Aug 15, 2022
@JonLiu1993
Copy link
Member

Feature [csv,dataset,example,filesystem,flight,json,orc,parquet,s3] tested successfully in the following triplet:

  • x64-windows
  • x64-windows-static

Feature 'cuda' tested failed :

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\memory(3128): error C2027: use of undefined type 'arrow::cuda::CudaDevice::Impl'
F:\Feature-test\arrow\vcpkg\buildtrees\arrow\src\rrow-9.0.0-b3a973f1b1.clean\cpp\src\arrow/gpu/cuda_context.h(140): note: see declaration of 'arrow::cuda::CudaDevice::Impl'
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\memory(3127): note: while compiling class template member function 'void std::default_delete<arrow::cuda::CudaDevice::Impl>::operator ()(_Ty *) noexcept const'
        with
        [
            _Ty=arrow::cuda::CudaDevice::Impl
        ]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\memory(3239): note: see reference to function template instantiation 'void std::default_delete<arrow::cuda::CudaDevice::Impl>::operator ()(_Ty *) noexcept const' being compiled
        with
        [
            _Ty=arrow::cuda::CudaDevice::Impl
        ]
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\memory(3164): note: see reference to class template instantiation 'std::default_delete<arrow::cuda::CudaDevice::Impl>' being compiled

@assignUser, can you take a look?

@assignUser
Copy link
Contributor Author

@JonLiu1993 Yes I am looking into it. I think the patch for this isn't to bad but I'll open a PR in apache/arrow and link it here.

@JonLiu1993
Copy link
Member

Feature [csv,dataset,example,filesystem,flight,json,orc,parquet,s3,cuda] tested successfully in the following triplet:

  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 16, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

@JavierMatosD JavierMatosD merged commit cd5e794 into microsoft:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[arrow] Linker errors with arrow[parquet]
4 participants