Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] fix dynamic build #25745

Closed
wants to merge 2 commits into from
Closed

[protobuf] fix dynamic build #25745

wants to merge 2 commits into from

Conversation

Jamlys
Copy link
Contributor

@Jamlys Jamlys commented Jul 13, 2022

Describe the pull request

  • What does your PR fix?

    Fix dynamic build.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Basically

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@dg0yt
Copy link
Contributor

dg0yt commented Jul 13, 2022

#25744. Please don't close and open new PR's without reason. If you need help, ask.

@Jamlys
Copy link
Contributor Author

Jamlys commented Jul 13, 2022

#25744. Please don't close and open new PR's without reason. If you need help, ask.

:( My fault. I am sorry for that.

@Adela0814 Adela0814 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 13, 2022
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Jul 14, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Jul 14, 2022

This change may be convenient, but patching individual ports for that is not the right way IMO.
If you need binaries working out of the box for x64-linux-dynamic, fix the general rpath/LD_LIBRARY_PATH gap. (That's you other PR.)
In the meantime, use a static host triplet.

@vicroms
Copy link
Member

vicroms commented Jul 14, 2022

depends on #23035

@vicroms vicroms added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 14, 2022
@Jamlys Jamlys closed this Jul 18, 2022
@Jamlys Jamlys deleted the ports_protobuf_fix_dynamic_build branch July 18, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:different-pr This PR or Issue depends on a PR which has been filed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants