Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eastl] Fix error C2039 with Visual Studio 2022 #25593

Merged
merged 2 commits into from
Jul 6, 2022
Merged

[eastl] Fix error C2039 with Visual Studio 2022 #25593

merged 2 commits into from
Jul 6, 2022

Conversation

LilyWangLL
Copy link
Contributor

In an internal version of Visual Studio, eastl install failed with following error:

D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1439): error C2039: '_FInf': is not a member of '`global namespace''
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1439): error C2065: '_FInf': undeclared identifier
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1442): error C2039: '_FNan': is not a member of '`global namespace''
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1442): error C2065: '_FNan': undeclared identifier
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1445): error C2039: '_FSnan': is not a member of '`global namespace''
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1445): error C2065: '_FSnan': undeclared identifier
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1448): error C2039: '_FDenorm': is not a member of '`global namespace''
D:\buildtrees\eastl\src\5ab9f1222a-55681b7249.clean\include\EASTL/numeric_limits.h(1448): error C2065: '_FDenorm': undeclared identifier

This error fixed by upstream PR electronicarts/EASTL#474, this PR is syncing up the fix to vcpkg.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 6, 2022
@LilyWangLL LilyWangLL requested a review from Cheney-W July 6, 2022 03:07
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jul 6, 2022
@vicroms vicroms merged commit 4b16144 into microsoft:master Jul 6, 2022
@LilyWangLL LilyWangLL deleted the dev/LilyWang/CI0704_eastl branch July 12, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilyWangLL @Cheney-W @vicroms